Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow download for get_pop_objs #50

Merged
merged 2 commits into from
Dec 11, 2023
Merged

Conversation

jdebacker
Copy link
Collaborator

This PR fixes an omission from PR #47, which allowed users to denote, for any function in demographics.py that can fetch data, whether they want to download data or look for local files. The download boolean was not fully passed to all functions called in demographics.get_pop_objs. This fixes that, allowing users to bypass any need for locally stored data files if they wish.

Copy link

codecov bot commented Dec 2, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2708ccb) 36.64% compared to head (2c6740a) 36.64%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #50   +/-   ##
=======================================
  Coverage   36.64%   36.64%           
=======================================
  Files           4        4           
  Lines         191      191           
=======================================
  Hits           70       70           
  Misses        121      121           
Flag Coverage Δ
unittests 36.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SeaCelo
Copy link
Collaborator

SeaCelo commented Dec 11, 2023

Looks good. Merging

@SeaCelo SeaCelo merged commit a34bb49 into EAPD-DRB:main Dec 11, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants